Invert order TrafficSplit and Emojivoto App #1908
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ivan Porta <[email protected]>
GTRekter
force-pushed
the
ivanp/updatefailover
branch
from
727c6e8 to
d3bc094
Compare
alpeb
reviewed
Jan 13, 2025
There was a problem hiding this comment.
This looks good, but I think it's a good opportunity to clarify why this ordering is required. I suggest you add a callout in the Service Profiles Feature doc explaining that the workload needs to be restarted if a ServiceProfile is created after the pod started (no need to provide further details). You can reference that paragraph from this tutorial.
Also it'd be great to also mention that subtlety in the Warning callout in the HTTPRoutes feature doc 🙏
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
create namespace and invert emojivoto deployment and trafficsplit