Fix hidden windows failures #359
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dalito
force-pushed
the
issue2460-fix-hidden-windows-failures
branch
from
d60d1a2 to
cf9e94b
Compare
dalito
changed the title
|
Closed because of wrong issue number in branch name. |
| @@ -152,7 +152,7 @@ def LOCAL_PATH_FOR(source: Source, fmt: Format) -> str: | |||
|
|
|||
|
|
|||
| def GITHUB_IO_PATH_FOR(source: Source, fmt: Format, version="latest") -> str: | |||
| path = '/'.join([version, 'linkml_model', *_build_path(source, fmt)]) | |||
There was a problem hiding this comment.
This is for a URL, not an OS path, which is why it joins on / rather than using pathlib. Looks like the pathlib impl should be equivalent but just explaining the manual string munging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes two Windows path-related issues that were undetected because of the gh-action.
See runs in #358 for the hidden failures that are fixed by this PR.
Closes linkml/linkml#2490