Transition to libusb and support targeting device by serial number #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 9, 2024
Closed
Closed
andersson
force-pushed
the
for-linux-msm/libusb-and-serial
branch
from
60485ad
to
a46c596
Compare
|
Gave this a spin on my Mac M3, built and runs. I'll try flashing tonight to confirm full function. Thanks @quic-bjorande! |
In order to support selecting board based on serial number the iProduct field needs to be inspected, with the hand-rolled parsing of the USB descriptors this becomes cumbersome. Furthermore the direct use of Linux's USBDEVFS creats an unnecessary dependency on the host OS being Linux. It's unclear why libusb wasn't choosen in the first place, perhaps it relates to the faint memory of 0.1 vs 1.0 packaging issues? Move to libusb-1.0 in order to resolve these issues, as well as clean up the code a bit. Signed-off-by: Bjorn Andersson <[email protected]>
When working on a host with multiple boards attached being able to select a specific board by serial number becomes necessary. In the EDL USB descriptors a device serial number is available as part of the iProduct string, so this can be used for comparison. As libusb requires a handle the libusb_open() needs to be moved into the loop. Signed-off-by: Bjorn Andersson <[email protected]>
andersson
force-pushed
the
for-linux-msm/libusb-and-serial
branch
from
a46c596
to
43976ff
Compare
|
That's awesome, will give it a try as well, thanks for doing the work! |
|
Tested flashing lmp/yocto image on a mac m3 and worked fine! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Transitioning to libusb avoids open-coded USB descriptor parsing and removes the strong dependency
on the Linux-specific ioctl-based interface.
This should allow QDL to run on other OSs, it cleans up the code a bit, and it allow us to more conveniently
implement reading of the string descriptors, for a serial number comparison, in the support for selecting a
specific board when more than one is available.