librdmacm: Use overloadable function attribute with clang #1475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It fails with musl as well, I will have to look into fixing it differently. |
This is to fix build warnings seen with upcoming clang19 and glibc 2.40, since glibc 2.40 has improved fortyfying this function with clang, it ends up with build errors like below librdmacm/preload.c:796:9: error: at most one overload for a given name may lack the 'overloadable' attribute | 796 | ssize_t recvfrom(int socket, void *buf, size_t len, int flags, | | ^ | /mnt/b/yoe/master/build/tmp/work/core2-64-yoe-linux/rdma-core/51.0/recipe-sysroot/usr/include/sys/socket.h:163:16: note: previous unmarked overload of function is here | 163 | extern ssize_t recvfrom (int __fd, void *__restrict __buf, size_t __n, | | ^ Upstream-Status: Submitted [linux-rdma#1475] Signed-off-by: Khem Raj <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to fix build warnings seen with upcoming clang19 and
glibc 2.40, since glibc 2.40 has improved fortyfying this
function with clang, it ends up with build errors like below
librdmacm/preload.c:796:9: error: at most one overload for a given name may lack the 'overloadable' attribute
| 796 | ssize_t recvfrom(int socket, void *buf, size_t len, int flags,
| | ^
| /mnt/b/yoe/master/build/tmp/work/core2-64-yoe-linux/rdma-core/51.0/recipe-sysroot/usr/include/sys/socket.h:163:16: note: previous unmarked overload of function is here
| 163 | extern ssize_t recvfrom (int __fd, void *__restrict __buf, size_t __n,
| | ^