Skip to content

Commit

Permalink
ci: use tox-lsr 3.3.1 which fixes py27 and related unit tests
Browse files Browse the repository at this point in the history
The latest version of virtualenv does not support creating
python 2.7 virtualenvs.  tox-lsr 3.3.1 restricts the version
of virtualenv<20.22.0

This PR also fixes some py unit test, pylint, and related
issues caused by using the latest versions of those tools.

For more information, see
linux-system-roles/tox-lsr#168

Signed-off-by: Rich Megginson <[email protected]>
  • Loading branch information
richm committed May 31, 2024
1 parent d04a7d6 commit 607bd76
Show file tree
Hide file tree
Showing 5 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/ansible-lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ jobs:
- name: Install tox, tox-lsr
run: |
set -euxo pipefail
pip3 install "git+https://github.com/linux-system-roles/[email protected].0"
pip3 install "git+https://github.com/linux-system-roles/[email protected].1"
- name: Convert role to collection format
run: |
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/ansible-managed-var-comment.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ jobs:
- name: Install tox, tox-lsr
run: |
set -euxo pipefail
pip3 install "git+https://github.com/linux-system-roles/[email protected].0"
pip3 install "git+https://github.com/linux-system-roles/[email protected].1"
- name: Run ansible-plugin-scan
run: |
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/ansible-plugin-scan.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ jobs:
- name: Install tox, tox-lsr
run: |
set -euxo pipefail
pip3 install "git+https://github.com/linux-system-roles/[email protected].0"
pip3 install "git+https://github.com/linux-system-roles/[email protected].1"
- name: Run ansible-plugin-scan
run: |
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/ansible-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ jobs:
- name: Install tox, tox-lsr
run: |
set -euxo pipefail
pip3 install "git+https://github.com/linux-system-roles/[email protected].0"
pip3 install "git+https://github.com/linux-system-roles/[email protected].1"
- name: Convert role to collection format
run: |
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/python-unit-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ jobs:
run: |
set -euxo pipefail
python -m pip install --upgrade pip
pip install "git+https://github.com/linux-system-roles/[email protected].0"
pip install "git+https://github.com/linux-system-roles/[email protected].1"
# If you have additional OS dependency packages e.g. libcairo2-dev
# then put them in .github/config/ubuntu-requirements.txt, one
# package per line.
Expand Down

0 comments on commit 607bd76

Please sign in to comment.