Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uefi: Do not copy if not necessary #305

Closed

Conversation

xaionaro
Copy link
Member

@xaionaro xaionaro commented Jan 31, 2020

Removed extra copies. It reduces memory consumption, improves performance and simplifies the result (it's now flat).

See the justification discussion: #304

Removed extra copies. It reduces memory consumption,
improves performances and simplifies the result.

ITS: linuxboot#304

Signed-off-by: Dmitrii Okunev <[email protected]>
@codecov-io
Copy link

Codecov Report

Merging #305 into master will decrease coverage by 0.05%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #305      +/-   ##
=========================================
- Coverage   39.26%   39.2%   -0.06%     
=========================================
  Files          47      47              
  Lines        3494    3489       -5     
=========================================
- Hits         1372    1368       -4     
+ Misses       1908    1907       -1     
  Partials      214     214
Impacted Files Coverage Δ
pkg/uefi/biosregion.go 6.66% <0%> (+0.1%) ⬆️
pkg/uefi/firmwarevolume.go 37.11% <100%> (-1.28%) ⬇️
pkg/uefi/file.go 16.55% <100%> (-1.14%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a816cc9...164658f. Read the comment docs.

@xaionaro xaionaro requested review from JulienVdG and GanShun and removed request for JulienVdG January 31, 2020 20:50
@GanShun
Copy link
Member

GanShun commented Jan 31, 2020

Let's discuss this a bit more on the issue. I ran into corruption last time without the copies, but we can do it better.

@xaionaro
Copy link
Member Author

xaionaro commented Feb 4, 2020

See #304 -- there's more details that are required to be considered, so the patch will be more complicated.

@xaionaro xaionaro closed this Feb 4, 2020
@xaionaro
Copy link
Member Author

xaionaro commented Nov 25, 2020

@GanShun : A service I implemented based on fiano, consumes too much memory (due to this copies). What you think if we will add support of a special read-only mode (which is required to enable explicitly through a global variable)?

@xaionaro
Copy link
Member Author

Closing the PR in favor to: #326

@xaionaro xaionaro closed this Jan 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants