dasharo flashrom: remove dummy and mtd for x86, put ast1100 as optional #1420
+24
−1,107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…11246 from work under https://github.com/Dasharo/flashrom/tree/kgpe-patch-rebase Pointing to Dasharo/flashrom#11 so that CircleCI shows success where work is happening Changes: - "WARNERROR=no" is a env variable interpreted at compilation now, not a configuration option anymore - ~To work around heads pkg-config, newer flashrom needs to have LIBS_BASE overriden to detect proper libusb and libpci as installed under heads/install~ fixed upstream in previous commits - INSTALL="$(INSTALL)" DESTDIR="$(INSTALL)" CFLAGS="-I$(INSTALL)/include/libusb-1.0 -I$(INSTALL)/include/pci" and LDFLAGS="-L$(INSTALL)/lib" needs to be passed as env variable to build properly - flashrom module now depends on libusb, since flashrom looks for pkg-config of installed libusb as prereq - flashrom ppc64: remove ast2400 and dummy, leaving NOTHING+MTD only NOTES: - newer flashrom version seems to need to have environment variables defined prior of make call on console, not passing options at make call - CONFIG_INTERNAL is not enough to have internal programmer anymore on x86. CONFIG_INTERNAL_X86 also needs to be requested. Collaboration happened under Dasharo/flashrom#11
ast1100 can now be added per board config settings. NExt commit does that for kgpe-d16
tlaurion
force-pushed
the
dasharo_flashrom_test_ast1100_optional
branch
from
1bbd583
to
e90d70b
Compare
This was referenced Jun 23, 2023
Merged
|
TODO:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
all x86 boards now only builds and pack internal programmer.
kgpe-d16 boards add ast1100 in their board config.
Talos II only builds and pack mtd programmer.
This is to see size reduction when combined with #1381 and #1350