-
-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
talos-2: kernel version bump to 6.6.16 #1802
base: master
Are you sure you want to change the base?
talos-2: kernel version bump to 6.6.16 #1802
Conversation
Signed-off-by: Thierry Laurion <[email protected]>
This looks like more relevant error:
|
Yes sorry @SergiiDmytruk , i didn't get the whole error log, pointed to circleci log after having modified OP |
Seems to be caused by |
Signed-off-by: Thierry Laurion <[email protected]>
…g, maybe some more patches needs porting Signed-off-by: Thierry Laurion <[email protected]>
@SergiiDmytruk @krystian-hebel kernel builds with 5261213 But patches still need porting for CBMEM output to file and maybe others (0010+) under https://github.com/linuxboot/heads/tree/79dc677d35e5f23f6dd787ce33753e3535233558/patches/linux-5.5-openpower Otherwise, no sealing/unsealing works. Pushed commit with kernel CBMEM support activated under facad5d which is needed since Talos II uses TPM event log replay to enforce sealing, and requires workaround for cbmem to be accessible as a file per previous implementation, which is a patch. |
You likely want an equivalent of that shebangs patch as well to avoid issues with Nix. Top part of 0010 might be necessary, and was probably done for 0011 to work. 0011 does look missing from upstream, |
Unneeded. Those patches were required prior of Linux kernel being made nix friendly somewhere after 5.15 if I recall well (Heads patches/linux* shows those patches not being required anymore, just as for coreboot newer releases that were made nix friendly as well). As can be seen with 5261213 being built by CI successfully.
@SergiiDmytruk facad5d added CONFIG_GOOGLE_CBMEM, while 0010 and 0011 (0010+ as said previously) needs to be reworked for this PR to be merged without regression for #1796 to be fixed and plan for feature freeze for next downstream releases and next qubesos release which might happen between downstream releases. I'm pointing work needing to be done here otherwise Talos-2 will go unmaintained. Unfortunately, I won't have much more time to fix this myself. |
@SergiiDmytruk modified OP for better task trackablility prior of next release, and assigned to you. |
Opened Dasharo/dasharo-issues#1133 |
This is WiP in goal of not putting Talos-2 unmaintained in tree and blocker for #1796
Current state of this PR: Builds but sealing/unsealing doesn't work.
@SergiiDmytruk @krystian-hebel : some patches are missing to be feature complete, as discussed at #1802 (comment)
TLDR TODOs, adapt:
Otherwise, Talos-2 cannot replay measurements from exposed CBMEM as file and sealing/unsealing of secret don't work.
OLD:
Fails as can been seen CircleCI https://app.circleci.com/pipelines/github/tlaurion/heads/2864/workflows/a472cced-20d2-4540-892e-e8d562a3e63a/jobs/53747?invite=true#step-102-48894_248
Patches having landed under
patches/linux-6.6.16-openpower
come from https://gitlab.raptorengineering.com/openpower-firmware/machine-talos-ii/op-build/-/tree/f89ea5cc89392de0d1bd6a554009809b5f68692c/openpower/linux and apply cleanly.Unfortunately, this fails with trace (
docker run -e DISPLAY=$DISPLAY --network host --rm -ti -v $(pwd):$(pwd) -w $(pwd) tlaurion/heads-dev-env:latest -- make -d BOARD=talos-2 #linux.modify_and_save_oldconfig_in_place
)EDIT:
Fixed by #1802 (comment)