Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support show battery percentage #1389

Merged
merged 1 commit into from
Oct 16, 2023
Merged

feat: support show battery percentage #1389

merged 1 commit into from
Oct 16, 2023

Conversation

Decodetalkers
Copy link
Contributor

Log:

@Decodetalkers Decodetalkers marked this pull request as draft July 26, 2023 09:11
@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Decodetalkers

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Decodetalkers Decodetalkers force-pushed the bluetoothbattery branch 3 times, most recently from 6af087a to 64e9ce9 Compare September 28, 2023 06:49
@Decodetalkers Decodetalkers changed the title WIP: support show battery percentage feat: support show battery percentage Sep 28, 2023
@Decodetalkers Decodetalkers marked this pull request as ready for review September 28, 2023 06:49
@Decodetalkers Decodetalkers requested a review from a team September 28, 2023 06:49
@Decodetalkers
Copy link
Contributor Author

@xzl01 你试试看呢

@Decodetalkers
Copy link
Contributor Author

/check obs

@deepin-bot
Copy link

deepin-bot bot commented Oct 9, 2023

Deepin ChatOps Bot
Deepin redeliveried failed, need update or recreate pull request!!!

@Decodetalkers Decodetalkers force-pushed the bluetoothbattery branch 3 times, most recently from 63eefed to b7c6691 Compare October 13, 2023 08:30
@Decodetalkers
Copy link
Contributor Author

/integrate

@deepin-community-ci-bot deepin-community-ci-bot bot mentioned this pull request Oct 13, 2023
Open
@github-actions
Copy link

AutoIntegrationPr Bot
auto integrate with pr url: deepin-community/Repository-Integration#564
PrNumber: 564
PrBranch: auto-integration-6505907617

@Decodetalkers
Copy link
Contributor Author

/integrate

@Decodetalkers Decodetalkers force-pushed the bluetoothbattery branch 2 times, most recently from 70278f6 to 2c4f0a6 Compare October 16, 2023 09:09
BLumia
BLumia reviewed Oct 16, 2023
View reviewed changes
Copy link
Member

@BLumia BLumia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

图标资源需要带吗？是不是应该用主题里的？

@Decodetalkers
Copy link
Contributor Author

Decodetalkers commented Oct 16, 2023 •
edited
Loading

图标资源需要带吗？是不是应该用主题里的？

主题里面的明暗反了。。亮色带了白色边框，暗色带了黑色边框，所以和dock一样处理了，因为之前那个提出开发者说这套主题反了，所以就自带了

@BLumia
Copy link
Member

BLumia commented Oct 16, 2023

主题里面的明暗反了。。亮色带了白色边框，暗色带了黑色边框，

@kegechen 看看谁处理下图标主题的问题？

@Decodetalkers
Copy link
Contributor Author

/merge

@deepin-bot deepin-bot bot merged commit 2ea09c2 into linuxdeepin:master Oct 16, 2023
@BLumia BLumia mentioned this pull request Nov 8, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BLumia BLumia BLumia left review comments

@dengbo11 dengbo11 dengbo11 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Decodetalkers @deepin-ci-robot @BLumia @dengbo11