Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: dialog set fix size #1955

Merged
merged 2 commits into from
Dec 25, 2024
Merged

chore: dialog set fix size #1955

merged 2 commits into from
Dec 25, 2024

Conversation

kegechen
Copy link
Contributor

@kegechen kegechen commented Dec 17, 2024

  • dialog set fix size to avoid resize(in treeland)
  • translation tweak
  • edit margin tweak

pms: Bug-297091, Bug-297629

image

image

@deepin-bot
Copy link

deepin-bot bot commented Dec 19, 2024

TAG Bot

New tag: 6.1.1
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #1964

@deepin-bot
Copy link

deepin-bot bot commented Dec 20, 2024

TAG Bot

New tag: 6.1.2
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #1969

@deepin-bot
Copy link

deepin-bot bot commented Dec 23, 2024

TAG Bot

New tag: 6.1.3
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #1971

caixr23
caixr23 previously approved these changes Dec 24, 2024
@deepin-bot
Copy link

deepin-bot bot commented Dec 24, 2024

TAG Bot

New tag: 6.1.4
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #1979

@kegechen kegechen force-pushed the dialog branch 2 times, most recently from efb24cd to e609653 Compare December 25, 2024 01:29
- dialog set fix size to avoid resize(in treeland)
- translation tweak
- right margin tweak
- hide/show edit button on item count changed
- edit button font size 12px

pms: Bug-297629
@deepin-ci-robot
Copy link

deepin pr auto review

代码审查意见:

  1. dccrepeater.cpp文件中,qmlWarning函数的调用被简化了,去掉了tr函数的调用,这可能会影响多语言支持。建议确认是否所有调用qmlWarning的地方都需要保持多语言支持。

  2. AccountSettings.qml文件中,font.pointSize的值从13变为了12,这可能会影响文本的可读性。建议确认是否所有地方都需要调整字体大小。

  3. AvatarGridView.qml文件中,新增了一个color属性,但是没有对应的注释说明其用途。建议添加注释说明该属性的作用。

  4. AvatarSettingsDialog.qml文件中,minimumWidthminimumHeight被设置为widthheight的值,这可能会导致窗口无法调整大小。建议确认是否需要这样的限制。

  5. ComfirmDeleteDialog.qmlComfirmSafePage.qml文件中,minimumWidthminimumHeight被设置为widthheight的值,这可能会导致窗口无法调整大小。建议确认是否需要这样的限制。

  6. CreateAccountDialog.qml文件中,minimumWidthminimumHeight被设置为widthheight的值,这可能会导致窗口无法调整大小。建议确认是否需要这样的限制。

  7. PasswordLayout.qml文件中,minWidth函数的计算中增加了20的偏移量,这可能会影响布局的准确性。建议确认是否所有情况下都需要这样的偏移量。

  8. PasswordModifyDialog.qml文件中,minimumWidthminimumHeight被设置为widthheight的值,这可能会导致窗口无法调整大小。建议确认是否需要这样的限制。

  9. DateTimeSettingDialog.qml文件中,minimumWidthminimumHeight被设置为widthheight的值,这可能会导致窗口无法调整大小。建议确认是否需要这样的限制。

  10. LangAndFormat.qml文件中,font.pointSize的值从13变为了12,这可能会影响文本的可读性。建议确认是否所有地方都需要调整字体大小。

  11. LangsChooserDialog.qml文件中,minimumWidthminimumHeight被设置为widthheight的值,这可能会导致窗口无法调整大小。建议确认是否需要这样的限制。

  12. RegionFormatDialog.qml文件中,minimumWidthminimumHeight被设置为widthheight的值,这可能会导致窗口无法调整大小。建议确认是否需要这样的限制。

  13. RegionsChooserWindow.qml文件中,minimumWidthminimumHeight被设置为widthheight的值,这可能会导致窗口无法调整大小。建议确认是否需要这样的限制。

  14. SearchableListViewPopup.qml文件中,placeholder属性的值从"搜索"变为了"Search",这可能会影响用户界面的本地化。建议确认是否所有地方都需要这样的修改。

  15. TimezoneDialog.qml文件中,minimumWidthminimumHeight被设置为widthheight的值,这可能会导致窗口无法调整大小。建议确认是否需要这样的限制。

  16. KeyboardLayout.qml文件中,font.pointSize的值从13变为了12,这可能会影响文本的可读性。建议确认是否所有地方都需要调整字体大小。

  17. LayoutsChooser.qml文件中,minimumWidthminimumHeight被设置为widthheight的值,这可能会导致窗口无法调整大小。建议确认是否需要这样的限制。

  18. ShortcutSettingDialog.qml文件中,minimumWidthminimumHeight被设置为widthheight的值,这可能会导致窗口无法调整大小。建议确认是否需要这样的限制。

  19. Shortcuts.qml文件中,font.pointSize的值从13变为了12,这可能会影响文本的可读性。建议确认是否所有地方都需要调整字体大小。

  20. translations目录下的所有.ts文件中,搜索被翻译为Search,这可能会影响用户界面的本地化。建议确认是否所有地方都需要这样的修改。

以上是针对代码修改的审查意见,希望能够帮助到您。

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: caixr23, kegechen

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kegechen kegechen merged commit efa159c into linuxdeepin:master Dec 25, 2024
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants