Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: disable timezone clock animation #1961

Merged
merged 1 commit into from
Dec 24, 2024

Conversation

kegechen
Copy link
Contributor

Temporarily disable animations
TODO: only enable animation on add timezone

@deepin-bot
Copy link

deepin-bot bot commented Dec 19, 2024

TAG Bot

New tag: 6.1.1
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #1964

@deepin-bot
Copy link

deepin-bot bot commented Dec 20, 2024

TAG Bot

New tag: 6.1.2
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #1969

@deepin-bot
Copy link

deepin-bot bot commented Dec 23, 2024

TAG Bot

New tag: 6.1.3
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #1971

Temporarily disable animations
TODO: only enable animation on add timezone
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • 移除了seconds属性和相关的代码,但未提供替代方案或说明。
  • 新增了animationEnabled属性,但未在文档中说明其用途和默认值。
  • SpringAnimationenabled属性绑定到clock.animationEnabled,但未提供动画的默认行为。

是否建议立即修改:

建议的修改:

  • 如果移除seconds属性和相关的代码是有意为之,应确保用户界面或功能不会受到影响,并且提供了相应的替代方案或说明。
  • 在新增的animationEnabled属性上添加文档注释,说明其用途、默认值以及如何影响动画行为。
  • 如果animationEnabledfalse时,应确保动画不会运行,或者提供默认的动画行为。

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: caixr23, kegechen

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kegechen kegechen merged commit 4395709 into linuxdeepin:master Dec 24, 2024
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants