Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Modify sidebar behavior #1968

Merged
merged 1 commit into from
Dec 24, 2024
Merged

feat: Modify sidebar behavior #1968

merged 1 commit into from
Dec 24, 2024

Conversation

caixr23
Copy link
Contributor

@caixr23 caixr23 commented Dec 19, 2024

Modify sidebar behavior

Log:
pms: TASK-361721

@deepin-bot
Copy link

deepin-bot bot commented Dec 20, 2024

TAG Bot

New tag: 6.1.2
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #1969

@deepin-bot
Copy link

deepin-bot bot commented Dec 23, 2024

TAG Bot

New tag: 6.1.3
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #1971

Modify sidebar behavior

Log:
pms: TASK-361721
@deepin-ci-robot
Copy link

deepin pr auto review

代码审查意见:

  1. DccWindow.qml:

    • 修改了appLicense的值,从"LGPL-3.0-or-later"改为"GPL-3.0-or-later",需要确认是否所有相关的文档和许可证文本都已更新。
    • 增加了D.StyledBehindWindowBlur组件,确保这个组件在所有目标平台上都能正常工作,并且不会影响性能。
    • 修改了minimumWidthminimumHeight的值,需要确认这些更改是否符合设计规范和用户体验要求。
  2. SecondPage.qml:

    • SplitView组件替换为Item组件,需要确保新的布局逻辑与原来的SplitView功能一致。
    • 增加了oldX属性,用于保存旧的分割器位置,需要确认这个属性的使用是否正确。
    • onPositionChanged函数中,增加了对newX的边界检查,确保分割器不会超出窗口范围。
  3. dccmanager.cpp:

    • 修改了width()height()函数中的默认值,需要确认这些更改是否符合应用程序的整体设计。
  4. DccRightView.qml:

    • 增加了margin属性,需要确保这个属性的使用不会影响其他布局组件。
  5. DccSettingsView.qml:

    • 增加了margin属性,需要确保这个属性的使用不会影响其他布局组件。
  6. DccUtils.js:

    • getMargin函数中增加了对窗口宽度的检查,确保在窗口宽度小于500时不会返回负值。
  7. main.cpp:

    • 移除了DGuiApplicationHelper相关的代码,需要确认这些更改不会影响应用程序的样式和主题。
  8. AccountSettings.qml:

    • 增加了lrMargin属性,需要确保这个属性的使用不会影响其他布局组件。
  9. accounts.qml:

    • 修改了icon属性的值,需要确认新的图标名称是否正确。
  10. display.qml:

    • 修改了icon属性的值,需要确认新的图标名称是否正确。

总体来说,这些更改看起来是合理的,但需要进一步确认每个更改是否符合应用程序的设计规范和用户体验要求。同时,需要确保所有相关的文档和许可证文本都已更新。

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: caixr23, kegechen

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@caixr23 caixr23 merged commit 5b604f5 into linuxdeepin:master Dec 24, 2024
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants