Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix pigz special character problem #193

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

lzwind
Copy link
Contributor

@lzwind lzwind commented Sep 19, 2024

Fix pigz special character problem

Log: Fix pigz special character problem
Bug: https://pms.uniontech.com/bug-view-274761.html

Fix pigz special character problem

Log: Fix pigz special character problem
Bug: https://pms.uniontech.com/bug-view-274761.html
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • addFiles函数中,使用了KPtyProcess代替QProcess,需要确认是否所有使用场景都兼容。
  • addFiles函数中,脚本的生成方式改变了,需要确保脚本的内容正确无误,并且安全性考虑。
  • connect信号连接的修改可能会导致原有的信号处理程序被覆盖,需要检查是否有遗漏的槽函数调用。
  • deleteProcess函数中增加了删除脚本文件的逻辑,需要确保脚本文件的删除不会影响其他进程或文件。

是否建议立即修改:

  • 是,需要确保代码的更改不会引入新的错误,并且与现有功能兼容。同时,应该进行充分的测试以确保更改后的代码能够正常工作。

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: lzwind, wyu71

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@lzwind
Copy link
Contributor Author

lzwind commented Sep 19, 2024

/merge

@deepin-bot deepin-bot bot merged commit 6f9a80e into linuxdeepin:release/eagle Sep 19, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants