Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 优化默认压缩7z效率 #255

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

myk1343
Copy link
Contributor

@myk1343 myk1343 commented Jan 7, 2025

优化默认压缩7z效率

Bug: https://pms.uniontech.com/bug-view-287203.html
Log: 优化默认压缩7z效率

优化默认压缩7z效率

Bug: https://pms.uniontech.com/bug-view-287203.html
Log: 优化默认压缩7z效率
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • slotFinishCalculateSize函数中新增了对stOptions.iCompressionLevel的赋值,但没有检查m_eStartupType是否为ST_Compresstozip7z,可能会导致在非压缩模式时修改了压缩级别。
  • DConfig的使用没有检查是否成功创建,可能会导致后续代码在dconfignullptr时引发空指针异常。

是否建议立即修改:

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: myk1343, pengfeixx

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@myk1343
Copy link
Contributor Author

myk1343 commented Jan 9, 2025

/merge

@deepin-bot deepin-bot bot merged commit 859c537 into linuxdeepin:release/eagle Jan 9, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants