Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remote server item text overlaps with buttons #342

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

ArchieMeng
Copy link
Contributor

@ArchieMeng ArchieMeng commented Apr 28, 2024

Extend elidedText limits when being hovered at

Issue: linuxdeepin/developer-center#7690
Log: Remote server item text overlaps with buttons

Extend elidedText limits when being hovered at

Issue: linuxdeepin/developer-center#7690
Log: Remote server item text overlaps with buttons
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • ItemWidget::paintEvent函数中,对QString的赋值应该在if判断的内部,以确保在m_funcButton可见时不会进行不必要的计算。
  • Utils::getElidedText函数的使用可能会导致性能问题,因为每次paintEvent调用都会计算文本的缩进,如果这个函数可以避免不必要的计算,应该考虑优化。

合并相似的问题是否建议立即修改:

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ArchieMeng, BLumia

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ArchieMeng ArchieMeng merged commit 10c8111 into linuxdeepin:master Apr 29, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants