Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: compile error #347

Merged
merged 1 commit into from
Jul 9, 2024
Merged

Conversation

rb-union
Copy link

@rb-union rb-union commented Jul 9, 2024

Fix cimpile error: header file not included.

Log: fix compile error

Fix compile error: header file not included.

Log: fix compile error
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • tabbar.cpp文件中新增的#include <QMimeData>是否确实需要,如果没有在其他文件中使用,应该移除以避免不必要的依赖。
  • termbasedialog.cpp文件中新增的DWIDGET_USE_NAMESPACE宏定义是否有必要,如果项目已经遵循了命名空间的使用,则可以移除。
  • 检查新增的#include <DGuiApplicationHelper>是否与项目中的其他部分存在冲突,如果有冲突,需要进行调整。

是否建议立即修改:

  • 是,应该立即检查并处理上述问题,以保持代码的整洁性和可维护性。

@myk1343
Copy link

myk1343 commented Jul 9, 2024

[是否满足兼容性要求] Y
[是否满足commit提交规范] Y
[是否满足编码规范] Y
[Review结论] Pass
[Fail原因] N/A

1 similar comment
@jeffshuai
Copy link

[是否满足兼容性要求] Y
[是否满足commit提交规范] Y
[是否满足编码规范] Y
[Review结论] Pass
[Fail原因] N/A

Copy link

@starhcq starhcq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/+1

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rb-union, starhcq

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rb-union
Copy link
Author

rb-union commented Jul 9, 2024

/merge

@deepin-bot deepin-bot bot merged commit d1c60f6 into linuxdeepin:release/eagle Jul 9, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants