Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: no single instance with debug build on #350

Merged
merged 1 commit into from
Aug 23, 2024

Conversation

hualet
Copy link
Contributor

@hualet hualet commented Aug 20, 2024

which is necessary when building/debugging deepin-terminal within a deepin-terminal session.

@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • #ifndef QT_DEBUG条件编译中,应该使用#if而不是#ifndef,以确保在调试模式下也能执行相应的代码。
  • DBusManager::callTerminalEntry(args);这行代码在#ifndef QT_DEBUG条件编译中不会被执行,这可能是一个逻辑错误,应该确认是否故意。

是否建议立即修改:

Copy link

github-actions bot commented Aug 20, 2024

CLA Assistant Lite bot:

如果你是以企业贡献者的身份进行提交,请联系我们签署企业贡献者许可协议
If you submit as corporate contributor, please contact us to sign our Corporate Contributor License Agreement

感谢您的提交,我们非常感谢。 像许多开源项目一样,在接受您的贡献之前,我们要求您签署我们的个人贡献者许可协议。 您只需发布与以下格式相同的评论即可签署个人贡献者许可协议
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Individual Contributor License Agreement before we can accept your contribution. You can sign the Individual Contributor License Agreement by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA.

Hualet Wang seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You can retrigger this bot by commenting recheck in this Pull Request

@hualet
Copy link
Contributor Author

hualet commented Aug 22, 2024

I have read the CLA Document and I hereby sign the CLA.

Copy link
Contributor

@ArchieMeng ArchieMeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ArchieMeng, hualet

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ArchieMeng ArchieMeng merged commit 8cc8579 into linuxdeepin:master Aug 23, 2024
12 of 14 checks passed
mhduiy pushed a commit to mhduiy/deepin-terminal that referenced this pull request Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants