Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Update changelog #376

Merged
merged 1 commit into from
Nov 30, 2024
Merged

Conversation

pengfeixx
Copy link

Update changelog

Log: Update changelog

Update changelog

Log: Update changelog
@deepin-ci-robot
Copy link

deepin pr auto review

这个提交主要是更新了 deepin-terminal 的版本号,从 5.9.49 升级到 5.9.50。从代码审查的角度来看,这个提交没有实质性的代码更改,因此主要关注的是提交信息(changelog)的规范性。

提交信息审查

  1. 版本号更新:确认版本号是否正确更新,并且符合语义化版本控制(Semantic Versioning)的规则。
  2. 提交信息格式:提交信息应该清晰、简洁,并且遵循 Debian 的提交信息格式。当前提交信息格式基本正确,但可以进一步优化。
  3. 描述性文字:描述性文字应该简明扼要,说明版本更新的主要变化或修复内容。当前提交信息只提到了版本号更新,没有具体说明变化内容。

改进建议

  1. 版本号更新:确保版本号更新正确,并且符合语义化版本控制规则。
  2. 提交信息格式:可以添加更多描述性文字,说明版本更新的具体内容,例如新增功能、修复的 bug 等。
  3. 描述性文字:确保描述性文字简明扼要,便于其他开发者快速理解版本更新的目的和内容。

修改后的提交信息示例

deepin-terminal (5.9.50) unstable; urgency=medium

  * 新增功能:支持自定义终端背景图片。
  * 修复 bug:修复在某些情况下终端窗口无法正常关闭的问题。

 -- xiepengfei <[email protected]>  Sat, 30 Nov 2024 13:13:27 +0800

这个修改后的提交信息提供了更详细的信息,有助于其他开发者理解版本更新的具体内容。

Copy link

TAG Bot

TAG: 5.9.50
EXISTED: no
DISTRIBUTION: unstable

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: lzwind, pengfeixx

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@lzwind lzwind merged commit 1c4791f into linuxdeepin:release/eagle Nov 30, 2024
16 checks passed
@pengfeixx pengfeixx deleted the changelog branch November 30, 2024 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants