Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync: from linuxdeepin/dtkdeclarative #151

Closed
wants to merge 1 commit into from

Conversation

deepin-ci-robot
Copy link
Contributor

Synchronize source files from linuxdeepin/dtkdeclarative.

Source-pull-request: linuxdeepin/dtkdeclarative#385

@deepin-ci-robot
Copy link
Contributor Author

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: deepin-ci-robot

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Aug 21, 2024

TAG Bot

New tag: 6.0.19
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #148

@deepin-ci-robot deepin-ci-robot force-pushed the sync-pr-385-nosync branch 6 times, most recently from adb81d0 to a2995d7 Compare August 27, 2024 09:47
@deepin-ci-robot
Copy link
Contributor Author

deepin pr auto review

关键摘要:

  • DQMLGlobalObjectPrivate构造函数中,使用lambda表达式连接qAppaboutToQuit信号到全局变量g_appAboutToQuit,但没有处理可能出现的槽函数未连接的错误情况。
  • DQuickControlColorSelector::updatePropertyFromName函数中,增加了对DQMLGlobalObjectPrivate::g_appAboutToQuit的检查,但没有更新注释来反映这一变化。

是否建议立即修改:

Synchronize source files from linuxdeepin/dtkdeclarative.

Source-pull-request: linuxdeepin/dtkdeclarative#385
@kegechen kegechen added the hold-on should not merge now label Sep 11, 2024
@kegechen
Copy link
Contributor

too many rebot prs

@kegechen kegechen closed this Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hold-on should not merge now
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants