fix: DciIcon can't load icon by source #248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
18202781743
requested review from
BLumia,
kegechen,
Aleksanaa,
asterwyx,
ComixHe and
FeiWang1119
18202781743
force-pushed
the
dciicon-from-source
branch
from
0403828 to
f2a8822
Compare
|
TAG Bot TAG: 5.6.20 |
18202781743
force-pushed
the
dciicon-from-source
branch
from
f2a8822 to
da9d664
Compare
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
Fallback to QQuickIconImage when `name` is empty, it will try to load icon by fallbackSource.
|
rebase 一下 |
|
/+1 |
18202781743
force-pushed
the
dciicon-from-source
branch
2 times, most recently
from
e14420d to
84670c1
Compare
kegechen
approved these changes
Dec 11, 2023
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: 18202781743, kegechen The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fallback to QQuickIconImage when
nameis empty, it will try toload icon by fallbackSource.