Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: animation tweak #384

Merged
merged 1 commit into from
Aug 22, 2024
Merged

Conversation

kegechen
Copy link
Contributor

  • switch animation duration 500ms
  • listview hovered background color remove shadowcolor
  • listview hovered background size adapt to hovered item's background

deepin-ci-robot added a commit to linuxdeepin/dtk6declarative that referenced this pull request Aug 20, 2024
Synchronize source files from linuxdeepin/dtkdeclarative.

Source-pull-request: linuxdeepin/dtkdeclarative#384
@deepin-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kegechen

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Aug 20, 2024

Doc Check bot
🟢 Document Coverage Check Passed!

- switch animation duration 500ms
- listview hovered background color remove shadowcolor
- listview hovered background size adapt to hovered item's background
@kegechen kegechen merged commit 23464c1 into linuxdeepin:dev/animation Aug 22, 2024
14 of 16 checks passed
@deepin-ci-robot
Copy link
Contributor

deepin pr auto review

关键摘要:

  • ListViewItem中,implicitWidthimplicitHeight的计算逻辑被修改,可能会影响列表项的布局和显示。需要确认这是否是预期的更改。
  • Switch组件中,toggletimerinterval被修改为500毫秒,这可能会影响切换操作的响应性。需要评估这是否是合适的更新。

是否建议立即修改:

  • 是,需要确保这些更改是经过充分测试和评估的,以避免潜在的布局和功能问题。

deepin-ci-robot added a commit to linuxdeepin/dtk6declarative that referenced this pull request Aug 22, 2024
Synchronize source files from linuxdeepin/dtkdeclarative.

Source-pull-request: linuxdeepin/dtkdeclarative#384
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants