Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: listview hover background color tweak #389

Merged
merged 1 commit into from
Aug 22, 2024

Conversation

kegechen
Copy link
Contributor

  • enableBoxShadow: false
  • dropShadowColor: null

deepin-ci-robot added a commit to linuxdeepin/dtk6declarative that referenced this pull request Aug 22, 2024
Synchronize source files from linuxdeepin/dtkdeclarative.

Source-pull-request: linuxdeepin/dtkdeclarative#389
@deepin-bot
Copy link
Contributor

deepin-bot bot commented Aug 22, 2024

Doc Check bot
🟢 Document Coverage Check Passed!

deepin-ci-robot added a commit to linuxdeepin/dtk6declarative that referenced this pull request Aug 22, 2024
Synchronize source files from linuxdeepin/dtkdeclarative.

Source-pull-request: linuxdeepin/dtkdeclarative#389
deepin-ci-robot added a commit to linuxdeepin/dtk6declarative that referenced this pull request Aug 22, 2024
Synchronize source files from linuxdeepin/dtkdeclarative.

Source-pull-request: linuxdeepin/dtkdeclarative#389
@deepin-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: FeiWang1119, kegechen

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

- enableBoxShadow: false
- dropShadowColor: null
deepin-ci-robot added a commit to linuxdeepin/dtk6declarative that referenced this pull request Aug 22, 2024
Synchronize source files from linuxdeepin/dtkdeclarative.

Source-pull-request: linuxdeepin/dtkdeclarative#389
@kegechen kegechen merged commit 66843b2 into linuxdeepin:dev/animation Aug 22, 2024
16 of 20 checks passed
@deepin-ci-robot
Copy link
Contributor

deepin pr auto review

关键摘要:

  • BoxPanel.qml中,enableBoxShadow属性的计算逻辑可能依赖于control.D.ColorSelector.family,但当前的依赖关系没有反映这种依赖关系。
  • ListView.qml中,enableBoxShadow属性被设置为false,这可能会影响组件的视觉样式,需要确认这是否是预期的行为。
  • ListView.qml中的dropShadowColor被设置为null,这可能会影响组件的视觉样式,需要确认这是否是预期的行为。

是否建议立即修改:

  • 是,需要确保属性的计算逻辑是正确的,并且不会引入新的问题。
  • 是,如果enableBoxShadow属性的设置会影响组件的视觉样式,应该立即进行修正。
  • 是,如果dropShadowColor的设置会影响组件的视觉样式,应该立即进行修正。

kegechen pushed a commit to linuxdeepin/dtk6declarative that referenced this pull request Sep 23, 2024
Synchronize source files from linuxdeepin/dtkdeclarative.

Source-pull-request: linuxdeepin/dtkdeclarative#389
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants