fix: Do not display AlertToolTip when alertText is empty #430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not display AlertToolTip when alertText is empty Log: pms: BUG-287159
deepin-ci-robot
added a commit
to linuxdeepin/dtk6declarative
that referenced
this pull request
Dec 7, 2024
Synchronize source files from linuxdeepin/dtkdeclarative. Source-pull-request: linuxdeepin/dtkdeclarative#430
deepin pr auto review关键摘要:
是否建议立即修改:
|
kegechen
reviewed
Dec 10, 2024
| @@ -32,7 +32,7 @@ Rectangle { | |||
| } | |||
|
|
|||
| Loader { | |||
| active: showAlert | |||
| active: showAlert && alertText.length !== 0 | |||
There was a problem hiding this comment.
应用端是不是更合适
LineEdit {
showAlert: alertText.length > 0
}
There was a problem hiding this comment.
可以加个检测，虽然showAlert主要是为了弹这个tooltip框的，
18202781743
approved these changes
Dec 13, 2024
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: 18202781743, caixr23 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
18202781743
pushed a commit
to linuxdeepin/dtk6declarative
that referenced
this pull request
Dec 13, 2024
Synchronize source files from linuxdeepin/dtkdeclarative. Source-pull-request: linuxdeepin/dtkdeclarative#430
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not display AlertToolTip when alertText is empty
Log:
pms: BUG-287159