Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: incorrect Highlight for Menu #450

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

18202781743
Copy link
Contributor

Adjust Item's width for ComboBox.
Remove ArrowListView's highlight.

pms: BUG-297137

Adjust Item's width for ComboBox.
Remove ArrowListView's highlight.

pms: BUG-297137
@18202781743 18202781743 requested a review from mhduiy January 8, 2025 08:22
deepin-ci-robot added a commit to linuxdeepin/dtk6declarative that referenced this pull request Jan 8, 2025
Synchronize source files from linuxdeepin/dtkdeclarative.

Source-pull-request: linuxdeepin/dtkdeclarative#450
@deepin-ci-robot
Copy link
Contributor

deepin pr auto review

代码审查意见:

  1. ArrowListView.qml 文件中,注释掉了 highlight 组件的 anchors 属性,但未提供替代方案或说明。如果 highlight 组件不再需要,应该完全移除该组件以避免混淆。

  2. ComboBox.qml 文件中,为 delegate 添加了 implicitWidth 属性,但没有提供具体的值或计算方式。如果 ListView.view.width 不能作为 implicitWidth 的合适值,应该使用更合适的值或计算方式。

  3. ComboBox.qml 文件中,移除了 delegatebackground 属性,但没有提供替代方案或说明。如果 background 属性不再需要,应该完全移除该属性以避免混淆。

  4. Menu.qml 文件中,移除了 delegatebackground 属性,但没有提供替代方案或说明。如果 background 属性不再需要,应该完全移除该属性以避免混淆。

  5. Menu.qml 文件中,为 view.highlight 组件添加了 visible: false 属性,但没有提供替代方案或说明。如果 view.highlight 组件不再需要,应该完全移除该组件以避免混淆。

  6. Menu.qml 文件中,为 highlightRect 组件添加了 visible: false 属性,但没有提供替代方案或说明。如果 highlightRect 组件不再需要,应该完全移除该组件以避免混淆。

  7. Menu.qml 文件中,移除了 highlightRect 组件的 anchors 属性,但没有提供替代方案或说明。如果 highlightRect 组件不再需要,应该完全移除该组件以避免混淆。

  8. Menu.qml 文件中,为 highlightRect 组件的 anchors 属性添加了 parent 的条件判断,但没有提供具体的条件或说明。如果条件判断是必要的,应该明确说明条件逻辑。

  9. Menu.qml 文件中,为 highlightRect 组件的 anchors 属性添加了 leftMargin 属性,但没有提供具体的值或计算方式。如果 leftMargin 属性是必要的,应该使用更合适的值或计算方式。

  10. 在所有修改的文件中,都添加了 TODO 注释,但没有提供具体的解决方案或说明。应该提供具体的解决方案或说明,以便其他开发者理解修改的目的和上下文。

总体来说,这些修改应该提供更多的上下文和说明,以便其他开发者更好地理解和维护代码。同时,应该确保所有修改都是必要的,并且不会引入新的问题。

@deepin-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 18202781743, mhduiy

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@18202781743 18202781743 merged commit ff46c34 into linuxdeepin:master Jan 8, 2025
19 of 21 checks passed
18202781743 pushed a commit to linuxdeepin/dtk6declarative that referenced this pull request Jan 8, 2025
Synchronize source files from linuxdeepin/dtkdeclarative.

Source-pull-request: linuxdeepin/dtkdeclarative#450
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants