Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Menu's focus not be clean #453

Merged
merged 1 commit into from
Jan 14, 2025
Merged

Conversation

18202781743
Copy link
Contributor

The bug can be see at QTBUG-99897.

pms: BUG-300051

The bug can be see at QTBUG-99897.

pms: BUG-300051
@18202781743 18202781743 requested a review from mhduiy January 13, 2025 06:06
@deepin-ci-robot
Copy link
Contributor

deepin pr auto review

关键摘要:

  • ColumnLayout 应该被包裹在 FocusScope 内部,而不是直接作为 contentItem 的子项。
  • topPaddingbottomPadding 的值被设置为 topPadding,这可能会导致无限递归,因为 topPadding 依赖于自身。

是否建议立即修改:

deepin-ci-robot added a commit to linuxdeepin/dtk6declarative that referenced this pull request Jan 13, 2025
Synchronize source files from linuxdeepin/dtkdeclarative.

Source-pull-request: linuxdeepin/dtkdeclarative#453
@deepin-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 18202781743, mhduiy

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@18202781743 18202781743 merged commit e2f51ee into linuxdeepin:master Jan 14, 2025
19 of 21 checks passed
18202781743 pushed a commit to linuxdeepin/dtk6declarative that referenced this pull request Jan 14, 2025
Synchronize source files from linuxdeepin/dtkdeclarative.

Source-pull-request: linuxdeepin/dtkdeclarative#453
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants