Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LMS foundation app #596

Closed
wants to merge 4 commits into from
Closed

Conversation

rpomaster
Copy link

No description provided.

@keriati
Copy link
Collaborator

keriati commented Jan 31, 2023

Seems like there are a lot of tests failing, please check and submit fixes.

@keriati keriati added bug Something isn't working bad or missing icon labels Jan 31, 2023
Copy link
Collaborator

@mvdkleijn mvdkleijn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @rpomaster I'm a new maintainer here and am running through some old PRs. Yours seems close to finished.

It had some typos, probably due to the original request at https://apps.heimdall.site/search?search=Logitech having a typo (missing L).

I've fixed those for you. If you could just add a nice logo in the proper format, then I think we're good to go.

Preferred format: SVG or PNG
In any case, check https://github.com/linuxserver/Heimdall-Apps/wiki/Image-requirements for icon requirements. Specifically 256x256 sizing for PNGs and the use of tinypng.com (for PNGs)

@mvdkleijn mvdkleijn removed the bug Something isn't working label Jan 24, 2024
@mvdkleijn
Copy link
Collaborator

No response in the past 14 days and this is older than six months. Closing to try and keep things organized.

Feel free to re-open / comment when applicable.

@mvdkleijn mvdkleijn closed this Feb 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants