Skip IPFS config if DISABLE_IPFS env var is set #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using the environment variable to check if it's set, skip if it is.
Changelog update for "Skip IPFS config" if env variable is set.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Thanks for opening this pull request! Be sure to follow the pull request template!
|
I am a bot, here are the test results for this PR:
|
thelamer
approved these changes
Jan 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Using the
DISABLE_IPFSenvironment variable to skip the IPFS config in theinit-emulatorjs-configscript if the variable is set. Also added a few double-quotes on some variables that were missing.Benefits of this PR and context:
It reduces startup time and resource use for users that have disabled IPFS.
How Has This Been Tested?
I have made a local build and tested, works fine for me. In my test setup, i also erase the remains of the
/data/.ipfs, but I have not done it in this pull request as it might not align with others views.Source / References:
N/A