Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add auth to the proxies table #767

Merged
merged 2 commits into from
Sep 25, 2023
Merged

Add auth to the proxies table #767

merged 2 commits into from
Sep 25, 2023

Conversation

quietsy
Copy link
Member

@quietsy quietsy commented Sep 22, 2023 •
edited
Loading

image

Behavior:

  • Auth status shows as enabled if all confs have at least one auth enabled for that app
  • Auth status shows as disabled if at least one conf doesn't have auth enabled for that app
  • Displays auth per conf when hovering over the auth status

Limitations:

  • Doesn't check that all locations have auth enabled, only checks if it's enabled somewhere in the conf
  • Stops searching in the conf when any auth is found, can't match multiple different auths to the same conf
  • Assumes a single proxy per conf

@quietsy quietsy requested a review from a team September 22, 2023 18:39
@LinuxServer-CI
Copy link

PR build pushed to ghcr.io/linuxserver/mods:pull_request_767

@LinuxServer-CI
Copy link

PR build pushed to ghcr.io/linuxserver/mods:pull_request_767

@aptalca aptalca self-assigned this Sep 22, 2023
@quietsy quietsy merged commit 6bd7e3b into swag-dashboard Sep 25, 2023
5 checks passed
@quietsy quietsy deleted the swag-dashboard-auth branch September 27, 2023 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aptalca aptalca aptalca approved these changes

Assignees

@aptalca aptalca

Labels
None yet
Projects
Issue & PR Tracker
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@quietsy @LinuxServer-CI @aptalca