Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for new swag_server_custom_directive label #778

Merged
merged 4 commits into from
Nov 2, 2023
Merged

Add support for new swag_server_custom_directive label #778

merged 4 commits into from
Nov 2, 2023

Conversation

aptalca
Copy link
Member

@aptalca aptalca commented Oct 30, 2023 •
edited
Loading

  • Inject a custom directive into the server block via swag_server_custom_directive label
  • Make compatible with upcoming cron changes
  • Sanitize swag_url sed replace

closes #764

@LinuxServer-CI
Copy link

PR build pushed to ghcr.io/linuxserver/mods:pull_request_778

@aptalca aptalca marked this pull request as ready for review October 31, 2023 16:46
@aptalca aptalca requested a review from a team October 31, 2023 16:46
@aptalca
Copy link
Member Author

aptalca commented Oct 31, 2023

tested locally

nemchik
nemchik requested changes Nov 2, 2023
View reviewed changes
Copy link
Member

@nemchik nemchik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from the one change suggestion, swag runs all other cron as abc now instead of root. there's no issue if this needs to run as root, but if it can be run as abc there would be some changes needed.

root/etc/s6-overlay/s6-rc.d/init-mod-swag-auto-proxy-setup/run Outdated Show resolved Hide resolved
@LinuxServer-CI
Copy link

PR build pushed to ghcr.io/linuxserver/mods:pull_request_778

@aptalca aptalca merged commit 67fc36c into swag-auto-proxy Nov 2, 2023
6 checks passed
@aptalca aptalca deleted the swag-auto-proxy-custom branch November 2, 2023 21:26
@aptalca aptalca mentioned this pull request Nov 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nemchik nemchik nemchik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Issue & PR Tracker
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aptalca @LinuxServer-CI @nemchik