restructure init to allow for plugins as mods #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am a bot, here are the test results for this PR:
|
thespad
approved these changes
Aug 27, 2024
|
I am a bot, here are the test results for this PR:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, netbox scripts (such as migrate) are run during init, before any mod scripts. This behavior prevents installing plugins as mods because in a fresh/recreated container, the plugin won't exist until the mods stage, but the plugin would be referenced in netbox config, leading to init errors when netbox migration runs.
This PR splits those init steps into a oneshot service (
svc-netbox-prepare) that runs after the mods are applied, but before the main netbox service is started.Ref: linuxserver/docker-mods#944