Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Use bash globbing instead of find.
find
doesn't seem to recognize any of the files in my/dev/dri
-folder as character special files. Bash's[[ -c file ]]
does.Also, using globbing should be a little bit safer. It's hard to loop over files from another program. So hard it's one of the top bash pitfalls. Using globbing is simpler and cleaner.
Benefits of this PR and context:
A little bit cleaner code, that also works on my system.
How Has This Been Tested?
I ran the script.
It's not a big change :)
podman version 5.2.3, on Debian Testing. Image id 88b59fbfee1f
Source / References: