Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically reopen sqlitebrowser when closed and remove minimize and close buttons from window decoration #9

Closed
wants to merge 2 commits into from

Conversation

baxerus
Copy link

@baxerus baxerus commented Dec 16, 2023

linuxserver.io


  • I have read the contributing guideline and understand that I have made the correct modifications

Description:

IMHO the main use case of this container is having easy access to sqlitebrowser and to nothing else.
As in, you start the container to use sqlitebrowser and start something else in the container.

So it makes sense to reopen sqlitebrowser, if you have closed it by mistake (because you started to container to use sqlitebrowser 😉).

For preventing accidentally closing sqlitebrowser the close button is removed from the window decoration. It is still possible to close the program, but it is more complicated and so less likely to happen by mistake.
And also the minimize button is removed, because the minimized window can not get easily maximized again.

Benefits of this PR and context:

The changes decrease the chance of bad user experience (e.g. window minimized and gone) and threfore improve the usability of the container.
And that with minimal and clear changes 👍

How Has This Been Tested?

Made a test build of the container and checked if it still works. It does 👍

Source / References:

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening this pull request! Be sure to follow the pull request template!

@LinuxServer-CI
Copy link
Contributor

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/sqlitebrowser/3.12.2-r3-pkg-398afa8a-dev-7fdce56d8d2f8360db28ac02e7822a0c62d83493-pr-9/index.html
https://ci-tests.linuxserver.io/lspipepr/sqlitebrowser/3.12.2-r3-pkg-398afa8a-dev-7fdce56d8d2f8360db28ac02e7822a0c62d83493-pr-9/shellcheck-result.xml

Tag Passed
amd64-3.12.2-r3-pkg-398afa8a-dev-7fdce56d8d2f8360db28ac02e7822a0c62d83493-pr-9
arm64v8-3.12.2-r3-pkg-398afa8a-dev-7fdce56d8d2f8360db28ac02e7822a0c62d83493-pr-9

@thelamer
Copy link
Member

thelamer commented Jan 2, 2024

This is actually by design we already pull the minimize button in the baseimage and the close exists because we allow the user to right click the desktop and open multiple if they want or reopen.
Auto re-opening has been discussed many times and some users actually like to close the apps when they are not using them in some cases so we go universally with this design.

We have stuff like the terminal and passwordless sudo in these images as they are geared to home server users without the consideration of this is a single pane of glass, we want people to tinker them out to be what they want. (apk install etc)

@baxerus
Copy link
Author

baxerus commented Jan 4, 2024

Okay 👍

Not conforming with all the design decisions, but that would be surprising by itself 😃

@baxerus baxerus closed this Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants