Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a readme typos #257

Closed
wants to merge 1 commit into from
Closed

Fix a readme typos #257

wants to merge 1 commit into from

Conversation

ZeonXr
Copy link

@ZeonXr ZeonXr commented Aug 17, 2024

linuxserver.io


  • I have read the contributing guideline and understand that I have made the correct modifications

Description:

Modify the incorrect package name "font-noto-cjk" to "fonts-noto-cjk"

Benefits of this PR and context:

How Has This Been Tested?

Source / References:

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening this pull request! Be sure to follow the pull request template!

@aptalca
Copy link
Member

aptalca commented Aug 17, 2024

Thanks for the PR, but the name is correct: https://pkgs.alpinelinux.org/package/v3.20/community/x86_64/font-noto-cjk

@aptalca aptalca closed this Aug 17, 2024
@LinuxServer-CI
Copy link
Contributor

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/webtop/c1365d22-pkg-c1365d22-dev-cf43b5bd57ee9743ba3f4f9419d992e46de6dc80-pr-257/index.html
https://ci-tests.linuxserver.io/lspipepr/webtop/c1365d22-pkg-c1365d22-dev-cf43b5bd57ee9743ba3f4f9419d992e46de6dc80-pr-257/shellcheck-result.xml

Tag Passed
amd64-c1365d22-pkg-c1365d22-dev-cf43b5bd57ee9743ba3f4f9419d992e46de6dc80-pr-257
arm64v8-c1365d22-pkg-c1365d22-dev-cf43b5bd57ee9743ba3f4f9419d992e46de6dc80-pr-257

@ZeonXr
Copy link
Author

ZeonXr commented Aug 17, 2024

Thanks for the PR, but the name is correct: https://pkgs.alpinelinux.org/package/v3.20/community/x86_64/font-noto-cjk

I use the debian-kde tag image and I need to pass the "INSTALL_PACKAGES=fonts-noto-cjk" environment variable to render cjk fonts correctly. However I just tried alpine-kde and "font-noto-cjk" works fine.

@aptalca
Copy link
Member

aptalca commented Aug 17, 2024

Different distros have different package names. What we provide is an example for the alpine base: https://github.com/linuxserver/docker-webtop/blob/master/readme-vars.yml#L133
To install cjk fonts on startup as an example pass the environment variables (Alpine base):

@ZeonXr ZeonXr deleted the fix-typo branch August 22, 2024 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

3 participants