Skip to content

Commit

Permalink
fix(landing): Only pass terrain request parameter to get style json a…
Browse files Browse the repository at this point in the history
…pi. BM-1068 (#3327)

### Motivation

We got terrain request parameter been passed to xyz and wmts api which
is confusing people and these api also not support terrain. So we should
only limit the terrain to pass into get style json only.

### Modifications
Only add terrain for style url.

### Verification
-- Removed from xyz and wmts

![image](https://github.com/user-attachments/assets/b40886ff-e581-4a4a-81ac-4a169a1767ae)

![image](https://github.com/user-attachments/assets/de46ac02-98a0-4ef4-81f4-8eec681468e9)

-- Only keep for style json url.

![image](https://github.com/user-attachments/assets/fc55ad4e-01c7-4068-83fa-81dcd6daef89)
  • Loading branch information
Wentao-Kuang authored Aug 18, 2024
1 parent 1655ea3 commit 1dfb33a
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion packages/landing/src/url.ts
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ export const WindowUrl = {
if (params.config != null) queryParams.set('config', ensureBase58(params.config));
if (params.pipeline != null) queryParams.set('pipeline', params.pipeline);
if (params.date?.before != null) queryParams.set('date[before]', params.date.before);
if (params.terrain != null) queryParams.set('terrain', params.terrain);
if (params.terrain != null && params.urlType === MapOptionType.Style) queryParams.set('terrain', params.terrain);

const imageFormat = params.imageFormat ?? WindowUrl.ImageFormat;
if (params.urlType === MapOptionType.Style) {
Expand Down

0 comments on commit 1dfb33a

Please sign in to comment.