Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): Update the create pr cli to import layer based on filename. #2887

Closed
wants to merge 1 commit into from

Conversation

Wentao-Kuang
Copy link
Contributor

@Wentao-Kuang Wentao-Kuang commented Aug 13, 2023

The reason I don't want the individual flag,

  • This makes argo workflow harder to use flag parameter as --individual means true instead of --individual true. We need a if condition in argo to determine whether to add the --individual flag instead of just pass the true as parameter.

  • Another reason is once we use the filename, this makes use better to manage if we have more different configs like import the imagery into historical.json config directly. So we just use --finename historical

@Wentao-Kuang Wentao-Kuang requested a review from a team as a code owner August 13, 2023 21:34
@blacha blacha closed this Dec 11, 2023
@Wentao-Kuang Wentao-Kuang deleted the feat/cli-pr-filename branch December 11, 2023 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants