Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): Update the import cli to output preview links for individual configs. BM-869 #2897

Merged
merged 3 commits into from
Aug 21, 2023

Conversation

Wentao-Kuang
Copy link
Contributor

@Wentao-Kuang Wentao-Kuang commented Aug 17, 2023

Why?

As we separated expired/disabled configs as individual config files in basemaps-config repo. Now we need the ci process to automatically pick the config changes and inserts for individual imagery.

Issue Link: BM-869

Description of Changes:

  • Update the basemaps cli import command to output changes for all tileset configs that only have a single layer.
  • relocate and reuse the prepare preview links logic into separated functions
  • Tested locally and test output markdown will update into PR comments soon.

Author Checklist:

  • Tests updated
  • Docs updated
  • Issue linked in PR title

@Wentao-Kuang Wentao-Kuang requested a review from a team as a code owner August 17, 2023 01:32
@Wentao-Kuang
Copy link
Contributor Author

Wentao-Kuang commented Aug 17, 2023

Local test output.

Aerial Config Inserts

test_aerial_geographx_nz_texture_shade_2012_8-0m

Aerial Config Updates

taupo_2023_0.075m

Individual Layer Inserts

test_individual_tauranga-urban-2017-0.1m

Individual Layer Updates

tauranga-winter-2022-0.1m

@dwsilk
Copy link
Member

dwsilk commented Aug 17, 2023

Looking good, but Individual Layer Inserts shouldn't have Aerial links?

@Wentao-Kuang
Copy link
Contributor Author

New test remove the aerial link for individual previews.

Aerial Config Inserts

test_aerial_geographx_nz_texture_shade_2012_8-0m

Aerial Config Updates

taupo_2023_0.075m

Individual Layer Inserts

test_individual_tauranga-urban-2017-0.1m

Individual Layer Updates

tauranga-winter-2022-0.1m

@dwsilk
Copy link
Member

dwsilk commented Aug 18, 2023

Perfect

@Wentao-Kuang Wentao-Kuang added this pull request to the merge queue Aug 21, 2023
Merged via the queue into master with commit e70280a Aug 21, 2023
10 checks passed
@Wentao-Kuang Wentao-Kuang deleted the feat/preview-individual branch August 21, 2023 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants