-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(lambda-tiler): update imagery layer attributions to show licensor details BM-897 #3357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blacha
reviewed
Oct 16, 2024
blacha
reviewed
Oct 16, 2024
blacha
reviewed
Oct 16, 2024
blacha
reviewed
Oct 16, 2024
tawera-manaena
changed the title
Update imagery layer attributions to show licensor details BM-897
feat(lambda-tiler): update imagery layer attributions to show licensor details BM-897
Oct 20, 2024
blacha
reviewed
Oct 20, 2024
blacha
reviewed
Oct 20, 2024
blacha
reviewed
Oct 20, 2024
blacha
reviewed
Oct 20, 2024
blacha
reviewed
Oct 23, 2024
blacha
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
As an Imagery Data Maintainer, I want to ensure that imagery is attributed to the correct licensor(s) for all published surveys so that councils and government departments receive appropriate recognition.
Attribution Types
stac_license
licensor_names
stac_license
licensor_names
-tileset_info
Modifications
packages/config-loader
providers
metadata when generating config files.packages/lambda-tiler
Updated the attribution endpoint to include
providers
metadata as part of collections when returningAttributionStac
responses.Updated the style endpoint to include a compact attribution on sources when returning
StyleJson
responses.packages/attribution
Verification
packages/lambda-tiler
packages/attribution
createLicensorAttribution()
generates the correct compact attribution for a given list of providers.Example
Layer: Top of the South 0.15m Flood Aerial Photos (2022)
Landing Page
Screenshot showing the extended attribution for the bottom-right of the landing page.
Styles Endpoint
/v1/styles/:styleName.json
Excerpt from the JSON response showing the provider metadata:
Attribution Endpoint
/v1/tiles/:tileSet/:tileMatrix/attribution.json
Excerpt from the JSON response showing the compact attribution for the layer source: