Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(landing): enable labels upon first visit BM-1101 #3364

Merged
merged 2 commits into from
Nov 3, 2024

Conversation

tawera-manaena
Copy link
Contributor

@tawera-manaena tawera-manaena commented Oct 29, 2024

Motivation

As a Basemaps user, I would like to see labels when I arrive at the site so I can see the context of the imagery displayed to me.

Modifications

Verification

  • Added additional tests to the landing package's map.config.test test suite.

Labels should be enabled

https://basemaps.linz.govt.nz
Viewing the aerial layer and not in debug mode. Enable labels upon first visit.

Labels should be disabled

https://basemaps.linz.govt.nz/?labels=false
The labels query string is present and equals false. Don't enable labels upon first visit.
https://basemaps.linz.govt.nz/?debug
In debug mode. Don't enable labels upon first visit.
https://basemaps.linz.govt.nz/?i=ashburton-2023-0.1m
Adjusted viewport to show imagery
Not viewing the aerial layer. Don't enable labels upon first visit.

Resolves bug: BM-1114

@tawera-manaena tawera-manaena added this pull request to the merge queue Nov 3, 2024
Merged via the queue into master with commit af656bf Nov 3, 2024
12 checks passed
@tawera-manaena tawera-manaena deleted the feat/show-labels-by-default branch November 3, 2024 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants