feat: Add topo-imagery version information to STAC TDE-1265 #1080
Conversation
l0b0
force-pushed
the
feat/add-technical-config-fields-to-stac
branch
from
5d5b704
to
542bf58
Compare
l0b0
force-pushed
the
feat/add-technical-config-fields-to-stac
branch
from
542bf58
to
cd888fc
Compare
| @@ -27,7 +27,7 @@ The scripts have been implemented to be run inside the Docker container only. Th | |||
| - Build the `Docker` image: | |||
|
|
|||
| ```bash | |||
| docker build . -t topo-imagery | |||
| docker build --build-arg=GIT_HASH=dev --build-arg=GIT_VERSION=dev --tag=topo-imagery . | |||
There was a problem hiding this comment.
do we need to make the local build commands more complicated? what value does adding "dev"/"dev" add here?
There was a problem hiding this comment.
There was some discussion about the best way to check that these exist when running in CI, open to suggestions! I think you are right we should change it as I can foresee they will end up commented out in the Dockerfile which would be a bad sign.
There was a problem hiding this comment.
This is the first command in the README.md it is likely what people will run to first build this system, is making this command much more complicated to add "dev" "dev" seem excessive?
There was a problem hiding this comment.
The reason for making these mandatory was to ensure that we don't forget to add them, which would only be detected at runtime.
Motivation
As a data maintainer, geospatial data engineer or data consumer, I would like to reference the technical configuration used to create the TIFFs in our ODR datasets in order to be able to recreate the TIFFs or carry out troubleshooting.
Modifications
Add
processing:software,processing:version, andprocessing:datetimeitem properties.Verification
pytest