Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: devcontainer TDE-598 #285

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

build: devcontainer TDE-598 #285

wants to merge 3 commits into from

Conversation

paulfouquet
Copy link
Collaborator

@paulfouquet paulfouquet commented Jan 6, 2023 •
edited
Loading

Description

Add a devcontainter to this repo in order to facilitate development in a Python with GDAL and Poetry dependencies environment.

Discussion

  • Persist bash history: everytime the devcontainer is re-built, the bash history is lost. Meaning that previous command used to do some test (example: run a Python script with multiple arguments) are lost. There is a way to store the commands history: https://code.visualstudio.com/remote/advancedcontainers/persist-bash-history
  • pjl: some of us use this tool to print the json logs in a pretty format. We could add this tool in the Docker container.

@paulfouquet paulfouquet requested a review from a team as a code owner January 6, 2023 02:33
paulfouquet
paulfouquet commented Jan 9, 2023
View reviewed changes
.devcontainer/post_start.sh
@@ -0,0 +1,4 @@
#!/bin/bash

git config --global --add safe.directory $1
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

microsoft/vscode-remote-release#7628

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix in devcontainer pre-release mentioned in microsoft/vscode-remote-release#7628 (comment) did not work for me

@paulfouquet paulfouquet marked this pull request as draft January 9, 2023 19:50
paulfouquet
paulfouquet commented Jan 9, 2023
View reviewed changes
Copy link
Collaborator Author

@paulfouquet paulfouquet left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Converted to draft as there is an issue with pre-commit install during the very first initialization of the container.
To reproduce, need to clean Docker cache docker builder prune

@paulfouquet
Copy link
Collaborator Author

Using devcontainer made my VSCode crashing few times. I've opened microsoft/vscode#170999

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@paulfouquet