This repository has been archived by the owner on Jun 20, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Strongly related to #2374 (follow-up: introduce
DELETE
), and thus to #2336 (physical deletion).The original aim of this was:
While doing this, I noticed that hide/delete functions were wrapped in extremely similar ways (including the aforementioned question) in the following five places:
@xi and I discussed the possibility to factor out this functionality. I suggested adding a 'resourceAction' - eventually this action should replace
adhDeleteAction
, sinceHIDE
should be used where 'mark-as-deleted' used to be used.In this PR,
resourceAction
calledadhHideAction
is implemented;the following use cases are replaced with
adhHideAction
:use case for this was deleting badge assignments, not blog contents.
Therefore @2e2a and I suggest to replace the delete action in
Blog.ts
with hide, even though I couldn't test it right now.)The following use cases are left untouched:
ResourceWidget
.TODO:
DELETE
(-> none),adhDeleteAction
(-> only Mercator2015).