fix(DAT-18966): hide delta properties for tables/views #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xtendedTableProperties changeSet for generated changelogs and diff-changelog when referenceDB is empty.
|
KushnirykOleh
approved these changes
Nov 5, 2024
SvampX
approved these changes
Nov 5, 2024
| /** | ||
| * Get the extended properties excluding delta parameters | ||
| */ | ||
| public static String getExtendedProperties(String tblProperties) { |
There was a problem hiding this comment.
Getting me bugged a bit, as far as we have an object ExtendedTableProperties, and this one represents filtered tblProperties. Could we rename this one?
There was a problem hiding this comment.
@SvampX, sorry, I will merge this ticket without this change to unblock testing of other tickets. Can we do this change is scope of some other PR?
There was a problem hiding this comment.
@SvampX you are right, naming it getFilteredTblProperties or removeDeltaPropertiesFromTblProperties would make more sense?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: delta properties for tables/views should not be present in the extendedTableProperties changeSet for generated changelogs and diff-changelog when referenceDB is empty.