Impersonation in E2E #704
Impersonation in E2E #704
Conversation
| options.debug ??= Boolean( | ||
| process.env.DEBUG && process.env.DEBUG !== "false", | ||
| ); | ||
| options.debug ||= envBool("DEBUG"); |
There was a problem hiding this comment.
I guess I’m missing something, but this seems like a weird behaviour to me:
- If env var
DEBUGis not set, then argument--debugwill be used -> fine - If env var
DEBUGis set to “false” or “no”, then argument--debugwill be used -> ?? - If env var
DEBUGis set to “true” or “yes”, then env var will be used -> ??
It seem inconsistent to me.
There was a problem hiding this comment.
I see your point, but it's not so easy. The previous behavior was completely broken, because ??= only has an effect on nullish values, but the way we've configured minimist, it returns false when a bool argument such as --debug is missing. Thus, it was impossible to enable debugging via the environment. In that sense, this is already an improvement.
The problem is this:
Note: options can also be set via corresponding environment variables,
e.g. --chain-id can be set via CHAIN_ID instead. Parameters take precedence over variables.
"Parameters take precedence" over variables, but a parameter declared boolean in minimist options is set to false by being omitted. So currently, there's no way to tell the difference between no --debug option being passed or explicitly passing e.g. --debug=false.
I guess we could remove the list of boolean options from the minimist config altogether, and do our own parsing...
No description provided.