RFC: better systemd --user integration
#301
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
intelfx
force-pushed
the
work/systemd-user
branch
from
038b071
to
68cd35e
Compare
Ignore $ppid if it is an instance of the systemd manager. This prevents `systemd --user` from being treated as a parent process of all non-double-forked `systemd --user` services.
Ideally, we'd do something more reasonable, like treating them similarly to system services and maybe even offering to restart some of them or at the very least printing them in a format suitable for copy-pasting, but for now just replace the process name with the service name and save them under a separate key to hopefully distinguish them from other processes under `systemd --user`.
intelfx
force-pushed
the
work/systemd-user
branch
from
68cd35e
to
470397c
Compare
|
Can this be useful for #289? |
|
@Vladimir-csp yes, I believe it can. This needs a bit more UI work (the code I wrote piggybacks on existing data structures used for raw session processes, so it does not offer to perform a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, processes running under
systemd --userconfuse needrestart in several ways:systemd --useras the logical parent (which means that needrestart will bogusly reportsystemditself as the process that needs to be restarted);systemd --userinstance itself needs a restart, needrestart won't do anything about it;systemd --user(as opposed to an arbitrary process started in a user scope), needrestart won't use this information in any way.This PR offers a clean solution for (1) by disregarding the parent if it is a
systemd --userinstance (implemented via matching the cgroup of the parent against/init.scope$), and pretty hacky solutions for (2) and (3) (hence the RFC status).