-
-
Notifications
You must be signed in to change notification settings - Fork 394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add support for v2 model_dump and v1 dict to pydantic plugin #3327
feat: Add support for v2 model_dump and v1 dict to pydantic plugin #3327
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3327 +/- ##
=======================================
Coverage 98.28% 98.28%
=======================================
Files 323 323
Lines 14777 14785 +8
Branches 2347 2345 -2
=======================================
+ Hits 14523 14531 +8
Misses 116 116
Partials 138 138 ☔ View full report in Codecov by Sentry. |
2c86e28
to
8046b36
Compare
8046b36
to
ca9b618
Compare
tests/e2e/test_pydantic.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the tests should probably go into tests/test_contrib/test_pydantic/test_plugin_serialization.py.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure about it.
We still need E2E for checking the passing arguments flow.
Will be ok for you if E2E will stay here and I add additional tests to test_plugin_serialization
?
…n-pydantic-plugin
…n-pydantic-plugin
…n-pydantic-plugin
Documentation preview will be available shortly at https://litestar-org.github.io/litestar-docs-preview/3327 |
Hi @provinzkraut, I've created a new PR that combines this one with strict validation: #3608 |
Do it @provinzkraut :) |
Superseded by #3608 |
Description
This is a continuation of #3171
The last unresolved conversation is here #3171 (comment)
Closes #3147