-
-
Notifications
You must be signed in to change notification settings - Fork 393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(channels): use SQL
function for psycopg
#3916
Conversation
7aac823
to
4ab7a11
Compare
4ab7a11
to
b9df07c
Compare
@provinzkraut Any ideas why these may be hanging now? I wouldn't have expected this change to use the built-in query helpers to have impacted this, but maybe so. |
Unfortunately no. Have you tried debugging the response from psycopg? Maybe it errors out weirdly and that causes our tests to get stuck waiting for something from a listener? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3916 +/- ##
=======================================
Coverage 98.36% 98.36%
=======================================
Files 346 346
Lines 15689 15690 +1
Branches 1737 1737
=======================================
+ Hits 15432 15433 +1
Misses 122 122
Partials 135 135 ☔ View full report in Codecov by Sentry. |
Quality Gate passedIssues Measures |
Documentation preview will be available shortly at https://litestar-org.github.io/litestar-docs-preview/3916 |
Description
This PR updates the channels backend to use the native psycopg
SQL
API.Additionally, it preemptively fixes some new warnings from upcoming pyright and ruff changes
Closes