Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(channels): use SQL function for psycopg #3916

Merged
merged 10 commits into from
Jan 4, 2025
Merged

fix(channels): use SQL function for psycopg #3916

merged 10 commits into from
Jan 4, 2025

Conversation

cofin
Copy link
Member

@cofin cofin commented Dec 30, 2024

Description

This PR updates the channels backend to use the native psycopg SQL API.

Additionally, it preemptively fixes some new warnings from upcoming pyright and ruff changes

Closes

@cofin cofin requested review from a team as code owners December 30, 2024 01:44
@cofin cofin changed the base branch from main to logging-13 December 30, 2024 04:12
@cofin
Copy link
Member Author

cofin commented Jan 3, 2025

@provinzkraut Any ideas why these may be hanging now? I wouldn't have expected this change to use the built-in query helpers to have impacted this, but maybe so.

@provinzkraut
Copy link
Member

@provinzkraut Any ideas why these may be hanging now? I wouldn't have expected this change to use the built-in query helpers to have impacted this, but maybe so.

Unfortunately no. Have you tried debugging the response from psycopg? Maybe it errors out weirdly and that causes our tests to get stuck waiting for something from a listener?

Base automatically changed from logging-13 to main January 3, 2025 18:04
Copy link

codecov bot commented Jan 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.36%. Comparing base (b3f2c5b) to head (b10b5e4).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3916   +/-   ##
=======================================
  Coverage   98.36%   98.36%           
=======================================
  Files         346      346           
  Lines       15689    15690    +1     
  Branches     1737     1737           
=======================================
+ Hits        15432    15433    +1     
  Misses        122      122           
  Partials      135      135           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarqubecloud bot commented Jan 4, 2025

@cofin cofin merged commit 93aa6bf into main Jan 4, 2025
26 checks passed
@cofin cofin deleted the psycopg-logging branch January 4, 2025 21:43
Copy link

github-actions bot commented Jan 4, 2025

Documentation preview will be available shortly at https://litestar-org.github.io/litestar-docs-preview/3916

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants