Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use "path" as an error message source #3920

Merged
merged 1 commit into from
Jan 3, 2025

Conversation

250MHz
Copy link
Contributor

@250MHz 250MHz commented Jan 3, 2025

Description

  • Use "path" as the "source" property for an error message if the key is a path parameter

Closes

Closes #3919

@250MHz 250MHz requested review from a team as code owners January 3, 2025 08:38
@github-actions github-actions bot added area/private-api This PR involves changes to the privatized API area/signature size: small type/feat pr/external Triage Required 🏥 This requires triage labels Jan 3, 2025
Copy link

codecov bot commented Jan 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.36%. Comparing base (1f8acc7) to head (9ba70d9).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3920   +/-   ##
=======================================
  Coverage   98.36%   98.36%           
=======================================
  Files         346      346           
  Lines       15687    15689    +2     
  Branches     1736     1737    +1     
=======================================
+ Hits        15430    15432    +2     
  Misses        122      122           
  Partials      135      135           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jan 3, 2025

Documentation preview will be available shortly at https://litestar-org.github.io/litestar-docs-preview/3920

Copy link
Member

@provinzkraut provinzkraut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @250MHz!

@provinzkraut provinzkraut merged commit 76632da into litestar-org:main Jan 3, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/private-api This PR involves changes to the privatized API area/signature pr/external size: small Triage Required 🏥 This requires triage type/feat
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhancement: Use "path" as an error message source in litestar._signature.SignatureModel._build_error_message
2 participants