fix: Updates AWS CSVs #614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ispeakc0de
previously approved these changes
Oct 4, 2023
neelanjan00
force-pushed
the
fix-aws-fault-csv
branch
from
a091a4b
to
6ef6c97
Compare
ksatchit
reviewed
Oct 4, 2023
| @@ -60,7 +60,7 @@ spec: | |||
| imagePullPolicy: Always | |||
| args: | |||
| - -c | |||
| - ./experiments -name ec2-stop-by-tag | |||
| - ./experiments -name ec2-terminate-by-tag | |||
There was a problem hiding this comment.
is this because image has entry point with ec2-terminate-by-tag? Is there a plan to change to stop here also.>
There was a problem hiding this comment.
Yes, in the future we can put a PR in litmus-go to rename it completely.
neelanjan00
force-pushed
the
fix-aws-fault-csv
branch
from
6ef6c97
to
2ec92d6
Compare
Signed-off-by: neelanjan00 <[email protected]>
neelanjan00
force-pushed
the
fix-aws-fault-csv
branch
from
2ec92d6
to
416e7ba
Compare
Signed-off-by: neelanjan00 <[email protected]>
neelanjan00
force-pushed
the
fix-aws-fault-csv
branch
from
bfa7bc1
to
82c390c
Compare
Saranya-jena
previously approved these changes
Oct 4, 2023
ispeakc0de
reviewed
Oct 4, 2023
Signed-off-by: neelanjan00 <[email protected]>
ispeakc0de
approved these changes
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates AWS CSVs