enchancement: updated naming convention from clientSet to dynamicClient (#203) #476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: nikzayn <[email protected]>
ispeakc0de
reviewed
Dec 26, 2023
| @@ -27,9 +27,9 @@ func CreateClientSet() (*kubernetes.Clientset, error) { | |||
| if err != nil { | |||
| return &kubernetes.Clientset{}, err | |||
| } | |||
| clientSet, err := kubernetes.NewForConfig(restConfig) | |||
| dynamicClient, err := kubernetes.NewForConfig(restConfig) | |||
There was a problem hiding this comment.
Can we revert this change as this is not a dynamic client?
ispeakc0de
reviewed
Dec 26, 2023
| kubeconfig string | ||
| config *restclient.Config | ||
| client *kubernetes.Clientset | ||
| dynamicClient *chaosClient.LitmuschaosV1alpha1Client |
There was a problem hiding this comment.
Can we change it to litmusClient as this is not a dynamic client? and change the rest of the places as well in this file
|
Closing this PR as it is not needed. We have closed the issue as well. Still, thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR updates the naming convention from clientSet to dynamicClient
Which issue this PR fixes
dynamicClientinstead toclientSet#203Special notes for your reviewer:
Checklist:
dynamicClientinstead toclientSet#203