Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auth: Changing PasswordEncryptionCost to reduce the latency in /login api #4878

Merged
merged 5 commits into from
Sep 18, 2024

Conversation

kartikaysaxena
Copy link
Contributor

Proposed changes

Decreased the cost of hashing of password as it was taking significant time.

Previously
login-api-before

After Changes
login-api-after

Types of changes

What types of changes does your code introduce to Litmus? Put an x in the boxes that apply

  • New feature (non-breaking change which adds functionality)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices applies)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the commit for DCO to be passed.
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added necessary documentation (if appropriate)

Dependency

  • Please add the links to the dependent PR need to be merged before this (if any).

Special notes for your reviewer:

Copy link
Contributor

@Saranya-jena Saranya-jena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work 🚀

@kartikaysaxena
Copy link
Contributor Author

Now the time taken is around 16ms
8-cost

@Saranya-jena
Copy link
Contributor

checks are failing @kartikaysaxena can you PTAL

@imrajdas
Copy link
Member

Thank you @kartikaysaxena

@imrajdas imrajdas changed the title Auth: change PasswordEncryptionCost Auth: Changing PasswordEncryptionCost to reducing the latency in /login api Sep 18, 2024
@imrajdas imrajdas changed the title Auth: Changing PasswordEncryptionCost to reducing the latency in /login api Auth: Changing PasswordEncryptionCost to reduce the latency in /login api Sep 18, 2024
@imrajdas imrajdas merged commit 0d755fc into litmuschaos:master Sep 18, 2024
19 checks passed
dusdjhyeon pushed a commit to dusdjhyeon/litmus that referenced this pull request Sep 24, 2024
… api (litmuschaos#4878)

* auth: change PasswordEncryptionCost

Signed-off-by: Kartikay <[email protected]>

* refactor: cost of encryption to 8

Signed-off-by: Kartikay <[email protected]>

* fix: fix goimports

Signed-off-by: Kartikay <[email protected]>

---------

Signed-off-by: Kartikay <[email protected]>
Co-authored-by: Kartikay <[email protected]>
Co-authored-by: Saranya Jena <[email protected]>
Signed-off-by: dusdjhyeon <[email protected]>
sagnik3788 pushed a commit to sagnik3788/litmus that referenced this pull request Oct 5, 2024
… api (litmuschaos#4878)

* auth: change PasswordEncryptionCost

Signed-off-by: Kartikay <[email protected]>

* refactor: cost of encryption to 8

Signed-off-by: Kartikay <[email protected]>

* fix: fix goimports

Signed-off-by: Kartikay <[email protected]>

---------

Signed-off-by: Kartikay <[email protected]>
Co-authored-by: Kartikay <[email protected]>
Co-authored-by: Saranya Jena <[email protected]>
Signed-off-by: sagnik3788 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants